Merged
Conversation
🦋 Changeset detectedLatest commit: b219870 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces enhancements to the IconMask and Textarea components, updates the icon theme styles, and modernizes the global CSS reset. The changes improve component flexibility, browser compatibility, and provide more robust baseline styles.
Changes:
- Added auto-grow functionality to the
Textareacomponent via a newgrowprop with comprehensive test coverage - Updated
IconMaskcomponent to usemaskImageinstead of shorthandmaskproperty and changed default display frominline-blocktoblock - Modified icon theme to use
widthinstead ofminWidthfor more predictable sizing with aspect ratio - Overhauled global CSS reset with improved baseline styles, better selector targeting, and additional resets for headings and links
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/theme-momotaro/src/components/icon.css.ts | Changed icon size variants from minWidth to width for consistent sizing |
| packages/reset/src/reset.css.ts | Comprehensive update to global CSS reset with improved selectors and additional resets |
| packages/react/src/components/form/Textarea/Textarea.tsx | Added grow prop to enable auto-growing textarea behavior |
| packages/react/src/components/form/Textarea/Textarea.test.tsx | Added comprehensive tests for the new grow prop and value rendering |
| packages/react/src/components/form/Textarea/Textarea.css.ts | Extracted fieldSizing into separate class for conditional application |
| packages/react/src/components/display/Icon/IconMask.tsx | Changed default display to block and updated to use maskImage property |
| packages/react/src/components/display/Icon/IconMask.test.tsx | Updated tests to verify maskImage instead of mask shorthand |
| packages/react/src/components/display/Icon/IconMask.stories.tsx | Refactored to define argTypes at meta level for better organization |
| packages/react/src/components/display/Icon/IconMask.css.ts | Added explicit maskPosition and maskRepeat for predictable rendering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to the
IconMaskandTextareacomponents, as well as updates to the global CSS reset and icon theme styles. The most significant changes include enhanced support for auto-growing textareas, improvements to icon masking and styling, and a more robust and modern CSS reset.Component Enhancements and Bug Fixes:
Textarea Component:
growprop to enable auto-growing behavior for the textarea. The corresponding class is conditionally applied, and comprehensive tests were added to ensure correct behavior. [1] [2] [3] [4]growprop, and prop forwarding.IconMask Component:
displayprop from'inline-block'to'block'for better layout consistency.maskImageinstead of the shorthandmaskproperty, improving browser compatibility and clarity. Associated tests were updated accordingly. [1] [2] [3]maskPositionandmaskRepeatfor more predictable rendering.argTypesat the meta level instead of per-story, streamlining configuration.Styling and Theming Updates:
CSS Reset:
Icon Theme:
widthinstead ofminWidth, ensuring icons have consistent sizing across variants.